Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pid_calibrate: allowing TUNE_PID_DELTA to pass through gcode #6346

Closed
wants to merge 3 commits into from

Conversation

SHKinsem
Copy link

@SHKinsem SHKinsem commented Sep 21, 2023

I have utilized the Bambulab hotend paired with a 70W ceramic heater cartridge. After extensive testing, it became evident that this setup exhibited an exceptionally rapid temperature response. This led to an issue where the original delta value was too small, causing the temperature sensor to be unable to collect data quickly enough, resulting in suboptimal PID calibration parameters. By adjusting the delta value, significant improvements can be achieved in the effectiveness of the automatic calibration process.

Signed-off-by: Jaccob Hui [email protected]

Tweaked for allowing TUNE_PID_DELTA to pass through gcode
@SHKinsem
Copy link
Author

With the change, new command would be 'PID_CALIBRATE HEATER= TARGET= TUNE_PID_DELTA='
if TUNE_PID_DELTA is not specified, default value would be 5.0

@SHKinsem SHKinsem changed the title Tweaking for allowing TUNE_PID_DELTA to pass through gcode Tweak for allowing TUNE_PID_DELTA to pass through gcode Sep 21, 2023
@SHKinsem SHKinsem changed the title Tweak for allowing TUNE_PID_DELTA to pass through gcode pid_calibrate: allowing TUNE_PID_DELTA to pass through gcode Sep 21, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@github-actions
Copy link

Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@github-actions github-actions bot closed this Oct 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant